-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toggle auditd #325
Toggle auditd #325
Conversation
Hey @njuettner, a test pull request has been created for you in the cluster-aws repo! Go to pull request giantswarm/cluster-aws#816 in order to test your cluster chart changes on AWS. |
Hey @njuettner, a test pull request has been created for you in the cluster-aws repo! Go to pull request giantswarm/cluster-aws#818 in order to test your cluster chart changes on AWS. |
There were differences in the rendered Helm template, please check! Output
|
@@ -205,6 +205,8 @@ Advanced configuration of components that are running on all nodes. | |||
|
|||
| **Property** | **Description** | **More Details** | | |||
| :----------- | :-------------- | :--------------- | | |||
| `global.components.auditd` | **Auditd** - Enable Auditd service.|**Type:** `object`<br/>| | |||
| `global.components.auditd.enabled` | **Enabled** - Whether or not the Auditd service shall be enabled. When true, the Auditd service is enabled. When false, the Auditd service is disabled.|**Type:** `boolean`<br/>**Default:** `false`| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just thinking out loud here: should we warn inhere about potential performance issues when enabling it?
Towards: giantswarm/roadmap#3669
I talked with Atlas and currently it's only needed for one customer. Enabling auditd leads to a lot of performance degradation (PTAL at the issue for further information) so we agreed to only enable it when needed.
By default we disable auditd:
Customer can enable it using
global.components.audit.enabled=true
Should this change be mentioned in the release notes?